Skip to content

Conversation

@ianthirdweb
Copy link
Contributor

@ianthirdweb ianthirdweb commented Oct 3, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR introduces a Guest Mode feature that allows users to start using the app without signing in. It includes documentation updates and examples for implementing this feature in both the inAppWallet and ConnectButton.

Detailed summary

  • Added a new entry for Guest Mode in the sidebar navigation.
  • Updated the details field in the guides for linked profiles to include Guest strategy.
  • Created a new documentation page for Guest Mode with usage examples.
  • Provided code snippets for creating a temporary guest account and linking profiles.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Signed-off-by: Ian Mukherjee <[email protected]>
@changeset-bot
Copy link

changeset-bot bot commented Oct 3, 2024

⚠️ No Changeset found

Latest commit: a7ab792

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2024 9:03am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
thirdweb_playground ⬜️ Skipped (Inspect) Oct 4, 2024 9:03am
thirdweb-www ⬜️ Skipped (Inspect) Oct 4, 2024 9:03am
wallet-ui ⬜️ Skipped (Inspect) Oct 4, 2024 9:03am

@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Oct 3, 2024
@codecov
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.61%. Comparing base (fb92f87) to head (a7ab792).
Report is 169 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4910      +/-   ##
==========================================
- Coverage   50.61%   47.61%   -3.00%     
==========================================
  Files        1024     1057      +33     
  Lines       54578    57224    +2646     
  Branches     3891     3924      +33     
==========================================
- Hits        27622    27247     -375     
- Misses      26323    29288    +2965     
- Partials      633      689      +56     
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 3dbcf77
packages 43.37% <ø> (-3.49%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

see 347 files with indirect coverage changes

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 41.96 KB (0%) 840 ms (0%) 494 ms (+25.08% 🔺) 1.4 s
thirdweb (cjs) 101.68 KB (0%) 2.1 s (0%) 898 ms (-7.64% 🔽) 3 s
thirdweb (minimal + tree-shaking) 4.82 KB (0%) 97 ms (0%) 106 ms (+58.35% 🔺) 202 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 116 ms (+146.68% 🔺) 126 ms
thirdweb/react (minimal + tree-shaking) 17.23 KB (0%) 345 ms (0%) 70 ms (-4.28% 🔽) 414 ms

@vercel vercel bot temporarily deployed to Preview – thirdweb-www October 4, 2024 08:44 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 4, 2024 08:44 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 4, 2024 08:44 Inactive
@joaquim-verges joaquim-verges merged commit 5dfde0f into main Oct 4, 2024
27 checks passed
@joaquim-verges joaquim-verges deleted the ian/guest-mode branch October 4, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Portal Involves changes to the Portal (docs) codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants